Relocations against STN_UNDEF

[Thomas Schwinge]

Hello!

On 2010-09-24 11:33, Alan Modra wrote:
> On Fri, Sep 24, 2010 at 11:45:42AM +0200, Thomas Schwinge wrote:
>> 	* elflink.c (bfd_elf_reloc_symbol_deleted_p): Compare the symbol index
>> 	to STN_UNDEF, not SHN_UNDEF.
>
> OK.

Committed.


>> -		      for (r_symndx = 0;
>> +		      for (r_symndx = STN_UNDEF;
>>  			   r_symndx < symtab_hdr->sh_info;
>>  			   r_symndx++)
>
> Please leave this, and the other 3 instances like it in elf32-ppc.c and
> elf64-ppc.c as zeros.

Yes, I admit: that looked a bit strange.  :-)

> I think it's also best to leave the struct mips_got_entry symndx
> valuse as zeros here and in later comparisons, because the comparisons
> probably ought to be "!= -1" rather than ">= 0".  Similaryly
> mips16_stub_symndx is using 0 as an error return so I think that
> should be left alone too.

Ack.

> So of the elfxx-mipx.c changes I'll OK the following.

Committed.

> The rest you'll
> need to argue with a mips maintainer if you want to push your patch.  ;-)

Nope.  :-)


Regards,
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100924/89c474db/attachment.sig>