[PATCH] Add plugin interface to LD [2/4] Claim files and add symbols.

Dave Korn dave.korn.cygwin@gmail.com
Fri Sep 24 01:23:00 GMT 2010


On 23/09/2010 06:31, Dave Korn wrote:

  More self-review:

> @@ -290,6 +301,59 @@ ldfile_try_open_bfd (const char *attempt,
>  	}
>      }
>  
> +#ifdef ENABLE_PLUGINS
> +  /* If plugins are active, they get first chance to claim
> +     any successfully-opened input file.  We skip archives
> +     here; the plugin wants us to offer it the individual
> +     members when we enumerate them, not the whole file.  We
> +     also ignore corefiles, because that's just weird.  It is
> +     a needed side-effect of calling  bfd_check_format with
> +     bfd_object that it sets the bfd's arch and mach, which 
> +     will be needed when and if we want to bfd_create a new
> +     one using this one as a template.  */
> +  int fildes = bfd_check_format (entry->the_bfd, bfd_object)
> +		? open (attempt, O_RDONLY


  Oops.  C99-style definition mingling amongst code; will have to refactor it
before commit.

    cheers,
      DaveK





More information about the Binutils mailing list