[PATCH ARM 6/6]: Architectural Extensions - Virtualization Extensions
Matthew Gretton-Dann
matthew.gretton-dann@arm.com
Thu Sep 23 15:55:00 GMT 2010
On Thu, 2010-09-23 at 16:30 +0100, Richard Earnshaw wrote:
> On Thu, 2010-09-23 at 10:24 +0100, Matthew Gretton-Dann wrote:
> > bfd/ChangeLog:
> > * bfd-in2.h (BFD_RELOC_ARM_HVC): Add.
> >
> > gas/ChangeLog:
> > 2010-09-22 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> >
> > * config/tc-arm.c (arm_ext_virt): Add.
> > (arm_reg_type): Add REG_TYPE_RNB for banked registers.
> > (reg_entry): Allow registers to be larger than a byte.
> > (reg_alias): Fix type warning.
> > (parse_operands): Parse banked registers when appropriate.
> > (do_mrs): Add support for Virtualization Extensions.
> > (do_hvc): Add.
> > (do_t_mrs): Add support for Virtualization Extensions.
> > (do_t_msr): Likewise.
> > (do_t_hvc): Add.
> > (SPLRBANK): Likewise.
> > (reg_names): Add banked registers.
> > (insns): Add support for Virtualization Extensions.
> > (md_apply_fixup): Likewise.
> > (arm_cpus): -mcpu=cortex-a15 implies the Virtualization
> > Extensions.
> > (arm_extensions): Add 'virt' extension.
> > (aeabi_set_public_attributes): Add support for Virtualization
> > Extensions.
> > doc/c-arm.texi: Document 'virt' extension.
> >
> > gas/testsuite/ChangeLog:
> > 2010-09-22 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> >
> > * gas/arm/armv7-a+virt.d: New test.
> > * gas/arm/armv7-a+virt.s: Likewise.
> > * gas/arm/attr-march-all.d: Update for Virtualization
> > Extensions.
> > * gas/arm/attr-march-armv7-a+sec+virt.d: New test.
> > * gas/arm/attr-march-armv7-a+virt.d: Likewise.
> >
> > include/opcode/ChangeLog:
> > 2010-09-22 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> >
> > * arm.h (ARM_EXT_VIRT): Add.
> > (ARM_ARCH_V7A_IDIV_MP_SEC): Rename...
> > (ARM_ARCH_V7A_IDIV_MP_SEC_VIRT): ...to this and include
> > Virtualization Extensions.
> >
> > opcodes/ChangeLog:
> > 2010-09-22 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> >
> > arm-dis.c (arm_opcodes): Add Virtualiztion Extensions support.
> > (thumb32_opcodes): Likewise.
> > (banked_regname): Add.
> > (print_insn_arm): Add Virtualization Extensions support.
> > (print_insn_thumb32): Likewise.
> >
> > Thanks,
> >
> > Matt
> >
>
> @@ -506,6 +507,7 @@ enum arm_reg_type
> ...
> + REG_TYPE_RNB,
> };
>
> C90 does not permit enums to end with a comma.
>
> + int flags = inst.operands[1].imm & (PSR_c|PSR_x|PSR_s|PSR_f|SPSR_BIT);
> + if (flags == 0)
>
> Blank line between declaration and block body. There are other instances of this elsewhere.
>
> Also the ChangeLog entries should be updated a previously mentioned.
>
> OK with those changes.
All six patches have now been committed:
1: http://sourceware.org/ml/binutils-cvs/2010-09/msg00170.html
2: http://sourceware.org/ml/binutils-cvs/2010-09/msg00171.html
3: http://sourceware.org/ml/binutils-cvs/2010-09/msg00172.html
4: http://sourceware.org/ml/binutils-cvs/2010-09/msg00173.html
5: http://sourceware.org/ml/binutils-cvs/2010-09/msg00174.html
6: http://sourceware.org/ml/binutils-cvs/2010-09/msg00175.html
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer - PDSW Tools
ARM Ltd
More information about the Binutils
mailing list