[PATCH] Add plugin interface to LD [2/4] Claim files and add symbols.

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Thu Sep 23 05:36:00 GMT 2010


Hi Dave,

* Dave Korn wrote on Thu, Sep 23, 2010 at 07:31:41AM CEST:
> --- a/ld/Makefile.am
> +++ b/ld/Makefile.am
> @@ -1989,7 +1989,7 @@ if ENABLE_PLUGINS
>  noinst_LTLIBRARIES = libldtestplug.la
>  libldtestplug_la_SOURCES = testplug.c
>  libldtestplug_la_CFLAGS= -g -O2
> -libldtestplug_la_LDFLAGS = -no-undefined -rpath /nowhere
> +libldtestplug_la_LDFLAGS = -no-undefined -rpath /nowhere -Wl,$(LIBIBERTY)

Why the '-Wl,' prefix?  I'd have expected $(LIBIBERTY) to be added to
libldtestplug_la_LIBADD.

If you need to work around libtool warning about adding static library
deps to a shared library, then I suggest at least -Wc, rather than -Wl,
but still I think you will run into troubles on static-only systems.

>  endif
>  
>  # DOCUMENTATION TARGETS

Cheers,
Ralf



More information about the Binutils mailing list