[PATCH] opcodes: blackfin: fix decoding of 32bit addresses on 64bit systems

Mike Frysinger vapier@gentoo.org
Tue Sep 21 09:19:00 GMT 2010


From: Robin Getz <robin.getz@analog.com>

The Blackfin ISA is very exact with regards to address truncation when
under/over flowing its 32bit range.  On a 32bit system, things work the
same and so addresses are decoded properly.  On a 64bit system though,
the decoded addresses may include the bits that are supposed to have
been truncated.  So force a 32bit truncation after the address has been
calculated.

Signed-off-by: Robin Getz <robin.getz@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2010-09-21  Robin Getz  <robin.getz@analog.com>

	* bfin-dis.c (fmtconst): Cast address to 32bits.
---
 opcodes/bfin-dis.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/opcodes/bfin-dis.c b/opcodes/bfin-dis.c
index b17e055..0aec087 100644
--- a/opcodes/bfin-dis.c
+++ b/opcodes/bfin-dis.c
@@ -138,6 +138,9 @@ fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info *outf)
       if (constant_formats[cf].pcrel)
 	ea += pc;
 
+     /* truncate to 32-bits for proper symbol lookup/matching */
+     ea = (bu32)ea;
+
      if (outf->symbol_at_address_func (ea, outf) || !constant_formats[cf].exact)
        {
 	  outf->print_address_func (ea, outf);
-- 
1.7.2



More information about the Binutils mailing list