RFC: COMDAT group names become anonymouse local symbols

Alan Modra amodra@gmail.com
Fri Oct 22 07:16:00 GMT 2010


On Thu, Oct 21, 2010 at 11:10:47PM -0700, Mark Mitchell wrote:
> 2010-10-21  Mark Mitchell  <mark@codesourcery.com>
> 
> 	* config/obj-elf.c (elf_adjust_symtab): New.  Move group section
> 	processing here from elf_frob_file.  Ensure that group signature
> 	symbols have the name of the group.
> 	(elf_frob_file): Move group section processing to
> 	elf_adjust_symtab.
> 	* config/obj-elf.h (elf_adjust_symtab): Declare.
> 	(obj_adjust_symtab): Define.
> 
> 2010-10-21  Mark Mitchell  <mark@codesourcery.com>
> 
> 	* gas/elf/elf.exp: Add group0c test.
> 	* gas/elf/group0c.d: New.
> 	* gas/elf/group0a.d: Expect ".group" for the name of group
> 	sections.
> 	* gas/elf/group0b.d: Likewise.
> 	* gas/elf/group1a.d: Likewise.
> 	* gas/elf/group1b.d: Likewise.
> 	* gas/elf/groupautoa.d: Likewise.
> 	* gas/elf/groupautob.d: Likewise.
> 	* gas/elf/section4.d: Likewise.

Looking good but needs a few more patches, and you need to run the
full binutils testsuite.

grep obj_adjust_symtab says you have a tweak to make to config/tc-arm.c
egrep '(group section|GROUP)' will hit a few more testcases in
gas/testsuite/gas/ia64/, binutils/testsuite/binutils-all/, and
ld/testsuite/ld-elf/

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list