[PATCH] Add plugin interface to LD [3/4] Get symbols and resolutions.

[Richard Henderson]

On 09/22/2010 10:31 PM, Dave Korn wrote:
> +      if (blhe->type == bfd_link_hash_common)
> +	{
> +	  /* Is this right?  The COMMON section only exists in the
> +	     output file, so it seems reasonable.  */
> +	  syms[n].resolution = LDPR_RESOLVED_EXEC;
> +	  continue;

Common symbols can be exported or not exported when generating a
shared library.  Another check is needed here.  In fact, I don't
see that you're doing any shared library preemption checking in
this function.

... that said, all that is elf-only; windows doesn't do library
symbol preemption.

> +  /* Suppresses "unused" warnings without relying on GCC attribute.  */
> +  info = info;
> +  value = value;

Er, I presume this is going away in a future patch?


r~