[PATCH 04/15] MIPS/GAS/test: Correct handling of arch overrides
Maciej W. Rozycki
macro@linux-mips.org
Sun Oct 3 19:40:00 GMT 2010
Hi,
In the MIPS/GAS testsuite some targets such as the mipstx39-*-* create an
additional "default" architecture. This arrangement breaks architecture
overrides, because in the case of this default architecture a name such
as "default = r3900" will be used in place of the usual "r3900" as it
would be in this case otherwise. If this happens run_dump_test_arch will
try the wrong override.
The fix for this problem is to fetch the actual name of the architecture
from its properties, that is a list whose first element is always the name
of concern. The fix follows.
2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
gas/testsuite/
* gas/mips/mips.exp (run_dump_test_arch): Get the name of the
architecture to check against for an architecture-specific test
from the properties instead of the name passed.
OK to apply?
Maciej
binutils-2.20.51-20100925-mips-gas-test-default.patch
Index: binutils-2.20.51/gas/testsuite/gas/mips/mips.exp
===================================================================
--- binutils-2.20.51.orig/gas/testsuite/gas/mips/mips.exp
+++ binutils-2.20.51/gas/testsuite/gas/mips/mips.exp
@@ -286,7 +286,8 @@ proc mips_arch_list_matching {args} {
proc run_dump_test_arch { name arch } {
global subdir srcdir
- set archname "${arch}@${name}"
+ set proparch [lindex [mips_arch_properties $arch 0] 0]
+ set archname "${proparch}@${name}"
if { [file exists "$srcdir/$subdir/${archname}.d"] } {
set name $archname
}
More information about the Binutils
mailing list