[committed] Fix fallout from MIPS LD & SD macro changes

Tristan Gingold gingold@adacore.com
Mon Nov 15 12:50:00 GMT 2010


On Nov 13, 2010, at 12:59 PM, Richard Sandiford wrote:

> The recent changes to the MIPS LD and SD macros trigger a GAS assertion
> for instructions like:
> 
> 	ld	$4,%gottprel(bar)($4)
> 
> (noticed as a failure to build libgomp on mips64-linux-gnu).
> The assertion was there to check the types of reloc that are generated
> by "real" macro expansion, but we now use 'o' to pass through normal
> LD and SD instructions on 64-bit targets, so several more types are
> possible.
> 
> One fix would have been to add all the reloc types in mips_percent_op to
> the assert.  However, I think that would run the risk of the two lists
> getting out of sync, and would probably also defeat the purpose of the
> original assert.  Instead, I've dropped the assert from the 'o' case and
> kept a restricted form for 'i' and 'j'.
> 
> Tested on mips64-linux-gnu and applied.  Tristan, since this fixes
> a GCC build failure, is it OK for the branch too?

Sure.

Tristan.



More information about the Binutils mailing list