[PATCH][ARM]: Fix unified syntax encoding of MOVS in Thumb.
Richard Earnshaw
rearnsha@arm.com
Fri May 28 15:07:00 GMT 2010
On Thu, 2010-05-27 at 16:59 +0100, Matthew Gretton-Dann wrote:
> Hi,
>
> Can someone please review the attached patch?
>
> GAS currently encodes a Thumb-state MOVS as ADDS in unified syntax mode,
> which is incorrect - it should be encoded as LSLS. This patch corrects
> this.
>
> Thanks,
>
> Matt
>
> Proposed ChangeLogs:
>
> gas/ChangeLog:
> 2010-05-27 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * config/tc-arm.c (do_t_mov_cmp): In unified syntax encode movs
> as lsls and not adds.
>
> gas/testsuite/ChangeLog:
> 2010-05-27 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * gas/arm/thumb2_it_auto.d: Update for change in movs encoding.
> gas/arm/thumb2_it.d: Likewise.
> gas/arm/thumb32.d: Likewise.
>
OK.
Note, however, that the disassembler should be fixed to disassemble
these instructions as MOV(S).
R.
More information about the Binutils
mailing list