[GOLD][PATCH] Remove Output_section::Simple_input_section class.
Doug Kwan (關振德)
Wed May 19 04:22:00 GMT 2010
在 2010年5月19日上午11:49，Ian Lance Taylor <firstname.lastname@example.org> 寫道：
>> @@ -1215,7 +1219,7 @@ class Arm_input_section : public Output_
>> // Address alignment of the original input section.
>> uint64_t original_addralign_;
>> // Section size of the original input section.
>> - uint64_t original_size_;
>> + off_t original_size_;
> This change doesn't seem quite right. Why should the size of a
> section be represented by an off_t value? off_t is for file offsets,
> not sizes. On the other hand, since this is ARM which is known to be
> a 32-bit target, it would be fine to use uint32_t here.
We use off_t for data_size() in Output_data and its sub-classes. I
changed this to make it consistent. I agree that uint32_t is
sufficient for ARM and will change this.
>> @@ -3104,13 +3100,16 @@ Output_section::get_input_sections(
>> return data_size;
>> -// Add an simple input section.
>> +// Add a script input section. SIS is an Output_section::Input_section,
>> +// which can be either a plian input section or a special input section like
>> +// a relaxed input section. For special input section, it's size must be
>> +// finalized.
Thanks for catching this. I will commit after making the suggested changes.
> This is OK with those changes.
More information about the Binutils