Fwd: [patch ld]: Enable autoimport for x64 by default

Kai Tietz ktietz70@googlemail.com
Sun May 16 13:49:00 GMT 2010


Ups xD


---------- Forwarded message ----------
From: Kai Tietz <ktietz70@googlemail.com>
Date: 2010/5/16
Subject: [patch ld]: Enable autoimport for x64 by default
To: Binutils <binutils@gmail.com>, Danny Smith <dansmister@gmail.com>,
Dave Korn <dave.korn.cygwin@googlemail.com>


Hello,

this patch set autoimport enabled for x64 targets by default.
Additionally it removes the option for pseudo-relocation-v1, as for
this target it would lead to an crash if using it.
The major issue (which could be possibly merged to pe.em too - if
autoimport enabled by default is wished - is the
gld_${EMULATION_NAME}_get_script function. At the moment it uses the
script, which moves rdata into data, which is caused by the v1
pseudo-relocation. As now for all targets v2 is default and v2 don't
need text/rdata to be marked as writable, this condition for
pei386_auto_import == 1 is just of interest when
pei386_runtime_pseudo_reloc != 2. By this pe.em could use also for x86
mingw the autoimport default enabling.

ChangeLog

2010-05-16  Kai Tietz

       * pep.em (gld_${EMULATION_NAME}_before_parse): Set auto-import
       default enabled.
       (gld_${EMULATION_NAME}_get_script): Check for rdata merge into data
       by pseudo-relocation-kind, too.
       (enum options): Remove OPTION_DLL_ENABLE_RUNTIME_PSEUDO_RELOC_V1.
       (gld${EMULATION_NAME}_add_options): Likewise.
       (gld${EMULATION_NAME}_handle_option): Likewise.
       (pep_find_data_imports): Remove warning about back-door
       enable of auto-import.

Tested for x86_64-pc-mingw32. Ok for apply?

Regards,
Kai

--
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination



-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
-------------- next part --------------
A non-text attachment was scrubbed...
Name: do_autoimp.diff
Type: application/octet-stream
Size: 3249 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100516/fc1f4158/attachment.obj>


More information about the Binutils mailing list