[RFA] Don't warn when using ld --wrap and code in Thumb-state on ARM

Alan Modra amodra@gmail.com
Tue Mar 30 08:58:00 GMT 2010


On Mon, Mar 29, 2010 at 04:48:27PM +0100, Matthew Gretton-Dann wrote:
> However, this change in symbol type is usually allowed for function
> symbols - _bfd_elf_merge_symbol indicates this.  But in this case this
> hasn't been allowed because the test for both symbols being function
> type symbols is done after an early exit for weak symbols.
> 
> The fix is to move the test for merging two function symbols, and so
> whether to allow a symbol type change earlier in _bfd_elf_merge_symbol.

I'd rather see a fix to the check for weak versioned symbols.  Ian
added that code here:
cvs diff -r 1.10 -r 1.11 elflink.h

And made a fix here:
cvs diff -r 1.19 -r 1.20 elflink.h

The test has remained functionally unchanged since.  Ian may have some
old mail archived that can shed some light on exactly why the test was
added.  I couldn't see anything for the first patch in the binutils
mail archives, and the bug-gnu-utils archive doesn't go back far
enough.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list