[PATCH] Fix ARM GAS segment fault

Jie Zhang jie@codesourcery.com
Fri Mar 19 14:50:00 GMT 2010


On 03/19/2010 08:55 PM, Daniel Jacobowitz wrote:
> On Fri, Mar 19, 2010 at 06:46:03PM +0800, Jie Zhang wrote:
>> ARM GAS crashes on the following test case now:
>>
>> nop
>> .fill 0, 0, 0
>> nop
>>
>> This .fill directive does not generate anything. So the mapping
>> symbol "$d" generated for this .fill will have the same value as the
>> "$a" generated for the second "nop", which GAS does not allow.
>>
>> To fix this case, this patch just allows two mapping symbols have the
>> same value and let the new one override the old one.
>>
>> No regression on GAS testsuite. Is it OK?
>
> OK.
>
Thanks. Committed. And I replaced the ChangeLog entry of the test with 
the one below.

	* gas/arm/mapmisc.s: Add the test case for two mapping
	  symbols having the same value.
	* gas/arm/mapmisc.d: Likewise.


-- 
Jie Zhang
CodeSourcery
(650) 331-3385 x735



More information about the Binutils mailing list