[RFA] Fix an i386 ld test FAIL

Jie Zhang jie@codesourcery.com
Wed Mar 17 15:59:00 GMT 2010


On 03/17/2010 09:52 PM, H.J. Lu wrote:
> On Wed, Mar 17, 2010 at 3:18 AM, Jie Zhang<jie@codesourcery.com>  wrote:
>> This patch fixes "Invalid allocated section" test in
>> ld/testsuite/ld-i386/i386.exp when testing ld on native i686-pc-linux-gnu.
>>
>> This test case consumes all the 1G memory + 1G swap when testing on my 32bit
>> i686 PC and finally times out.
>>
>> For the section .foo in that test case, sec->vma == 0 and p->p_vaddr +
>> p->p_memsz == 0xc0100008. So in the following statement:
>>
>>   bfd_signed_vma adjust = sec->vma - (p->p_vaddr + p->p_memsz);
>>
>> adjust is 0x3feffff8 because we are doing 32bit calculation. Thus the
>> expected "overlaps preious sections" error is not reported.
>>
>> Regtested with native i686-pc-linux-gnu. Is this patch OK?
>>
>
> Thanks for fixing it. I checked it as an obvious fix.
>
Thanks!

Jie



More information about the Binutils mailing list