[RFA] [ARM] Fix reporting of undefined and deprecated mov rd, rm instructions

Richard Earnshaw rearnsha@arm.com
Wed Jun 30 16:28:00 GMT 2010


On Mon, 2010-06-28 at 17:27 +0100, Matthew Gretton-Dann wrote:
> Hi,
> 
> In Thumb state gas rejects mov sp, sp.  In fact this instruction is
> allowed (but deprecated).
> 
> The attached patch fixes this case, and other related cases where the
> disassembler was incorrectly accepting or rejecting variants of mov rd,
> rm in Thumb state.  Please can someone review and if appropriate approve
> it?
> 
> Thanks,
> 
> Matt
> 
> Proposed ChangeLogs:
> 
> gas/ChangeLog:
> 2010-06-28  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* config/tc-arm.c (do_t_mov_cmp): Fix reporting of 
> 	unpredictable and deprecated mov register instructions.
> 
> gas/testsuite/ChangeLog:
> 2010-06-28  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* gas/arm/thumb2_bad_reg.s: Update mov register tests.
> 	* gas/arm/thumb2_bad_reg.l: Likewise.

This is OK.

R.



More information about the Binutils mailing list