[Patch/RFA]: Patch to fix R_ARM_THM_JUMP24 relocation truncated bug

Matthew Gretton-Dann matthew.gretton-dann@arm.com
Mon Jan 25 12:00:00 GMT 2010


On Tue, 2010-01-19 at 14:32 +1030, Alan Modra wrote:
> On Mon, Jan 18, 2010 at 02:36:36PM +0000, Matthew Gretton-Dann wrote:
> >         * ld-arm/jump-reloc-veneers-long.d: New test.
> >         * ld-arm/jump-reloc-veneers-short1.d: Likewise.
> >         * ld-arm/jump-reloc-veneers-short2.d: Likewise.
> >         * ld-arm/jump-reloc-veneers.s: Likewise.
> >         * ld-arm/arm-elf.exp (armelftests): Run them.
> 
> One of these tests fails on arm-linux with current mainline sources.
> Please retest and fix.

Apologies for the delay in responding.

The failing test is because targets supporting the old ABI do not
support Thumb-2.  Nor do I believe that there are any plans to add this
support.

The attached patch moves the new tests to only run under arm*-*-*eabi
targets.

There are other tests currently run for all ARM targets that make use of
Thumb-2 and therefore fail under the old ABI.  If the current patch is
approved I will submit a second one which moves these tests so that they
only run under the new ABI.

Suggested ld/testsuite/ChangeLog entry is:

2010-01-18  Matthew Gretton-Dann <matthew.gretton-dann@arm.com>

	* ld-arm/jump-reloc-veneers-long.d: New test.
	* ld-arm/jump-reloc-veneers-short1.d: Likewise.
	* ld-arm/jump-reloc-veneers-short2.d: Likewise.
	* ld-arm/jump-reloc-veneers.s: Likewise.
	* ld-arm/arm-elf.exp (armelftests): Run them.

Thanks,

Matt

-- 
Matthew Gretton-Dann
Principal Engineer - Tools, PD Software
ARM Limited
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1001-jump-veneers-tests.patch
Type: text/x-patch
Size: 3675 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100125/d9b1f365/attachment.bin>


More information about the Binutils mailing list