GNU_STACK header is not present when linking with gc-sections.

Sriraman Tallam tmsriram@google.com
Fri Jan 15 01:45:00 GMT 2010


Submitted this patch.

2010-01-14  Sriraman Tallam  <tmsriram@google.com>

	* object.cc (Sized_relobj::do_layout): Change to call layout_gnu_stack
	in the first pass of do_layout.


Index: object.cc
===================================================================
RCS file: /cvs/src/src/gold/object.cc,v
retrieving revision 1.117
diff -u -u -p -r1.117 object.cc
--- object.cc	8 Jan 2010 22:34:34 -0000	1.117
+++ object.cc	15 Jan 2010 01:43:41 -0000
@@ -1321,7 +1321,7 @@ Sized_relobj<size, big_endian>::do_layou
         }
     }

-  if (!is_gc_pass_one)
+  if (!is_gc_pass_two)
     layout->layout_gnu_stack(seen_gnu_stack, gnu_stack_flags);



On Thu, Jan 14, 2010 at 5:41 PM, Ian Lance Taylor <iant@google.com> wrote:
> Sriraman Tallam <tmsriram@google.com> writes:
>
>> Index: object.cc
>> ===================================================================
>> RCS file: /cvs/src/src/gold/object.cc,v
>> retrieving revision 1.117
>> diff -u -u -p -r1.117 object.cc
>> --- object.cc 8 Jan 2010 22:34:34 -0000       1.117
>> +++ object.cc 15 Jan 2010 00:34:15 -0000
>> @@ -1321,7 +1321,7 @@ Sized_relobj<size, big_endian>::do_layou
>>          }
>>      }
>>
>> -  if (!is_gc_pass_one)
>> +  if (!is_gc_pass_two)
>>      layout->layout_gnu_stack(seen_gnu_stack, gnu_stack_flags);
>>
>>
>> Is this ok to submit ?
>
> This is OK with a ChangeLog entry, if it fixes the problem.
>
> Thanks.
>
> Ian
>



More information about the Binutils mailing list