[PATCH][GOLD] Add Cortex-A8 stub class.
Ian Lance Taylor
iant@google.com
Thu Jan 7 04:36:00 GMT 2010
"Doug Kwan (關振德)" <dougkwan@google.com> writes:
> enum Type
> {
> THUMB16_TYPE = 1,
> + THUMB16_SPECIAL_TYPE,
> THUMB32_TYPE,
> ARM_TYPE,
> DATA_TYPE
> };
The other values are pretty obvious from the name, but I think this
new one needs a comment.
> +// Cortex-A8 stub class. We need a Cortex-A8 stub to redirect any 32-bit
> +// THUMB branch that meets the following conditions:
> +//
> +// 1. The branch straddles across a page boundary. i.e. lower 12-bit of
> +// branch address is 0xffe.
> +// 2. The branch target address in the same page as the first word of the
> +// branch.
s/in/is in/ ?
> +// 3. The branc is follows a 32-bit instruction which is not a branch.
s/branc is/branch/
> +// To do the fix up, we need to store address of the branch instruction
s/store/store the/
> + // Retun the section index of the code section containing the branch being
> + // fixed up.
s/Retun/Return/
This is OK with those changes.
Thanks.
Ian
More information about the Binutils
mailing list