[RFA] Objdump broken on 2.20 branch for ARM.

Matthew Gretton-Dann matthew.gretton-dann@arm.com
Thu Feb 18 14:31:00 GMT 2010


Hi,

I think this commit did not fix up the mis-applied patch correctly:

> On Thu, 2010-01-21 at 12:03 +0000, nickc@sourceware.org wrote:
> CVSROOT:	/cvs/src
> Module name:	src
> Branch: 	binutils-2_20-branch
> Changes by:	nickc@sourceware.org	2010-01-21 12:03:13
> 
> Modified files:
> 	opcodes        : ChangeLog arm-dis.c 
> 
> Log message:
> 	* arm-dis.c: Fix mis-applied patch.
> 
> Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.1438.2.20&r2=1.1438.2.21
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/opcodes/arm-dis.c.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.106.2.2&r2=1.106.2.3

When running the gas testsuite I am getting 22 unexpected failures, all
of which are aborts in objdump when disassembling 32-bit Thumb-2
instructions, and which are not present before the patch was applied.

The attached patch fixes the problem, by reinserting a break statement
that the previous patch removed.

Can someone review and approve this patch please?  This only applies to
the bintuils 2.20 branch.

Thanks,

Matt

-- 
Matthew Gretton-Dann
Principal Engineer - Tools, PD Software
ARM Limited
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1002-fixup-break-misplacement.patch
Type: text/x-patch
Size: 458 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100218/471b3a01/attachment.bin>


More information about the Binutils mailing list