Include sysdep.h before stdio.h in ldlex.c

Richard Sandiford rdsandiford@googlemail.com
Wed Feb 10 19:54:00 GMT 2010


Nick Clifton <nickc@redhat.com> writes:
> Hi Richard,
>
>> Does this look OK to you?  Nick?
>
> I still think that you ought to have a comment in ldlex-wrapper.c 
> explaining why it is necessary,

Doh!  Sorry Nick, completely forgot to add that yesterday.
Here's what I used:

/* The flex output (ldlex.c) includes stdio.h before any of the C code
   in ldlex.l.  Make sure we include sysdep.h first, so that config.h
   can select the correct value of things like _FILE_OFFSET_BITS and
   _LARGE_FILES.  */

> but apart from that I have no other 
> objections and I am happy to approve it.

Applied, thanks.

Richard



More information about the Binutils mailing list