[PATCH]: gold sparc unaligned...

[David Miller]

From: Ian Lance Taylor <iant@google.com>
Date: Mon, 08 Feb 2010 15:49:57 -0800

> David Miller <davem@davemloft.net> writes:
> 
>> BTW, when playing around with fixing this in GAS I noticed that the
>> gold testsuite doesn't use GAS from the build tree.
> 
> When running the assembler directly it ought to use the one from the
> build tree.  It's true that when running the compiler it does not pass
> a -B option to use the assembler in the source tree.  Do you think it
> should?

Passing in -B to get the in-tree assembler would be a good way
to find regressions when doing development, I think.

>> 2010-02-08  David S. Miller  <davem@davemloft.net>
>>
>> 	* sparc.cc (Target_sparc::Relocate::relocate): If relocation offset is
>> 	unaligned for R_SPARC_16, R_SPARC_32, or R_SPARC_64, use the unaligned
>> 	relocation helper function.
> 
> This is OK if you add a comment at each site explaining why we are
> doing things in this less efficient way.

Ok, will do.

> I'm actually surprised this doesn't work since I thought the Solaris
> linker did enforce the alignment requirement.  Or is it that it works
> with the Solaris assembler but not gas?  In which case this patch is
> still OK, I guess, but we should also fix gas.

I really have no idea.  I doubt many people test with GAS but not GNU
ld on Solaris.