gold: fix testsuite dependencies.

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Thu Dec 16 22:03:00 GMT 2010


* Ian Lance Taylor wrote on Thu, Dec 16, 2010 at 05:21:16AM CET:
> Ralf Wildenhues writes:
> > 	* testsuite/Makefile.am (ifuncmain2static_DEPENDENCIES)
> > 	(ifuncmain2_DEPENDENCIES, ifuncmain4static_DEPENDENCIES)
> > 	(ifuncmain4_DEPENDENCIES, ifuncmain5static_DEPENDENCIES)
> > 	(ifuncmain5_DEPENDENCIES, ifuncmain7static_DEPENDENCIES)
> > 	(ifuncmain7_DEPENDENCIES): Add $(DEPENDENCIES).
> > 	* testsuite/Makefile.in: Regenerate.
> 
> This is the wrong way around.  All of the tests should have their own
> empty _LDADD variable.
> 
> That patch is preapproved.

Ah, right.  Committed like this.

Thanks,
Ralf

gold: fix testsuite dependencies.

gold/ChangeLog:
2010-12-16  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* testsuite/Makefile.am (ifuncmain2static_LDADD)
	(ifuncmain2_LDADD, ifuncmain4static_LDADD, ifuncmain4_LDADD)
	(ifuncmain7static_LDADD, ifuncmain7_LDADD): New empty variables,
	to avoid unneeded links against $(LDADD).
	* testsuite/Makefile.in: Regenerate.

diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 530b5be..b3d969f 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -1621,6 +1621,7 @@ check_PROGRAMS += ifuncmain2static
 ifuncmain2static_SOURCES = ifuncmain2.c ifuncdep2.c
 ifuncmain2static_DEPENDENCIES = gcctestdir/ld
 ifuncmain2static_LDFLAGS = -Bgcctestdir/ -static
+ifuncmain2static_LDADD =
 
 check_PROGRAMS += ifuncmain2picstatic
 ifuncmain2picstatic: ifuncmain2pic.o ifuncdep2pic.o gcctestdir/ld
@@ -1630,6 +1631,7 @@ check_PROGRAMS += ifuncmain2
 ifuncmain2_SOURCES = ifuncmain2.c ifuncdep2.c
 ifuncmain2_DEPENDENCIES = gcctestdir/ld
 ifuncmain2_LDFLAGS = -Bgcctestdir/
+ifuncmain2_LDADD =
 
 check_PROGRAMS += ifuncmain2pic
 ifuncmain2pic: ifuncmain2pic.o ifuncdep2pic.o gcctestdir/ld
@@ -1653,6 +1655,7 @@ check_PROGRAMS += ifuncmain4static
 ifuncmain4static_SOURCES = ifuncmain4.c
 ifuncmain4static_DEPENDENCIES = gcctestdir/ld
 ifuncmain4static_LDFLAGS = -Bgcctestdir/ -static
+ifuncmain4static_LDADD =
 
 check_PROGRAMS += ifuncmain4picstatic
 ifuncmain4picstatic: ifuncmain4pic.o gcctestdir/ld
@@ -1662,6 +1665,7 @@ check_PROGRAMS += ifuncmain4
 ifuncmain4_SOURCES = ifuncmain4.c
 ifuncmain4_DEPENDENCIES = gcctestdir/ld
 ifuncmain4_LDFLAGS = -Bgcctestdir/
+ifuncmain4_LDADD =
 
 ifuncmain5pic.o: ifuncmain5.c
 	$(COMPILE) -c -fpic -o $@ $<
@@ -1727,6 +1731,7 @@ check_PROGRAMS += ifuncmain7static
 ifuncmain7static_SOURCES = ifuncmain7.c
 ifuncmain7static_DEPENDENCIES = gcctestdir/ld
 ifuncmain7static_LDFLAGS = -Bgcctestdir/ -static
+ifuncmain7static_LDADD =
 
 check_PROGRAMS += ifuncmain7picstatic
 ifuncmain7picstatic: ifuncmain7pic.o gcctestdir/ld
@@ -1736,6 +1741,7 @@ check_PROGRAMS += ifuncmain7
 ifuncmain7_SOURCES = ifuncmain7.c
 ifuncmain7_DEPENDENCIES = gcctestdir/ld
 ifuncmain7_LDFLAGS = -Bgcctestdir/
+ifuncmain7_LDADD =
 
 check_PROGRAMS += ifuncmain7pic
 ifuncmain7pic: ifuncmain7pic.o gcctestdir/ld



More information about the Binutils mailing list