[PATCH] do not require dc in gold testsuite
Allan McRae
allan@archlinux.org
Fri Dec 10 11:57:00 GMT 2010
On 10/12/10 05:13, Ian Lance Taylor wrote:
> Allan McRae<allan@archlinux.org> writes:
>
>> This is a partial reversion of the changes made in
>> http://sourceware.org/ml/binutils-cvs/2010-08/msg00004.html which
>> appear to have been made to improve portability of the hex to decimal
>> conversion. However, I find the requirement of needing "dc" installed
>> for the test suite to succeed to be excessive. Instead, implement the
>> conversion in a third way using printf, which should provide the
>> portability without requiring additional software.
>
> Neither the shell builtin printf nor the printf command are portable to
> all Unix systems. The dc command is more portable than both.
>
> I don't object to not requiring dc, but requiring printf instead is a
> step sideways at best.
>
Would it be acceptable to fall back to using the print version if dc is
not installed?
The other option is to adjust the test from being a failure to being
unsupported on systems where dc is not installed.
Allan
More information about the Binutils
mailing list