[PATCH 03/20] MIPS/GAS: Message capitalisation fixes (correction)

Richard Sandiford rdsandiford@googlemail.com
Tue Dec 7 09:59:00 GMT 2010


Patches 1-2 OK.

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> @@ -10005,7 +10005,7 @@ mips_ip (char *str, struct mips_cl_insn 
>  		  && imm_expr.X_op == O_constant
>  		  && (imm_expr.X_add_number < 0
>  		      || imm_expr.X_add_number >= 0x10000))
> -		as_bad (_("lui expression not in range 0..65535"));
> +		as_bad (_("LUI expression not in range 0..65535"));
>  	      s = expr_end;
>  	      continue;

Things like this (picked just as an example, I realise there are others)
introduce a different inconsistency: other messages give opcodes in
lower case.

Patch is OK without the hunks that capitalise opcodes.  If you still
want to do something about the messages that start with opcodes,
please send that as a separate patch, rather than resending the
whole thing.

Richard



More information about the Binutils mailing list