[PATCH 08/20] MIPS/GAS: Improve a LUI complaint message

Hans-Peter Nilsson hp@bitrange.com
Mon Dec 6 01:38:00 GMT 2010


On Thu, 2 Dec 2010, Maciej W. Rozycki wrote:
> 2010-12-02  Maciej W. Rozycki  <macro@codesourcery.com>
>
> 	gas/
> 	* config/tc-mips.c (mips_ip)['u']: Report the value of the LUI
> 	argument complained about; reword the message.

Just a bikeshed comment from the sideline: The [] in changelog-
entries is canonically for conditionally defined stuff; within
#ifdef X/#if X.  For case statements, the canonical marking is
<case X> or <X>, like:

	* config/tc-mips.c (mips_ip) <case 'u'>: Report the value of the LUI
or
	* config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI

Feel free to ignore this, I just don't want your format to catch
on - and possibly be forced to use it. ;)

brgds, H-P



More information about the Binutils mailing list