[gold patch obvious] Remove unnecessary code in Sort_commons::operator()

Cary Coutant ccoutant@google.com
Wed Aug 18 19:37:00 GMT 2010


This patch just removes some unnecessary code that was equivalent to a
NOP. Committed as obvious (after verifying with Ian that the original
code wasn't trying to do something more subtle).

-cary


        * common.cc (Sort_commons::operator()): Remove unnecessary code.


Index: common.cc
===================================================================
RCS file: /cvs/src/src/gold/common.cc,v
retrieving revision 1.24
diff -u -p -r1.24 common.cc
--- common.cc	3 Aug 2010 14:07:13 -0000	1.24
+++ common.cc	18 Aug 2010 18:30:13 -0000
@@ -88,16 +88,7 @@ bool
 Sort_commons<size>::operator()(const Symbol* pa, const Symbol* pb) const
 {
   if (pa == NULL)
-    {
-      if (pb == NULL)
-	{
-	  // Stabilize sort.  The order really doesn't matter, because
-	  // these entries will be discarded, but we want to return
-	  // the same result every time we compare pa and pb.
-	  return pa < pb;
-	}
-      return false;
-    }
+    return false;
   if (pb == NULL)
     return true;



More information about the Binutils mailing list