[PATCH] MIPS/LD: Fix up testsuite breakage from gettextisation

Nick Clifton nickc@redhat.com
Tue Aug 17 10:16:00 GMT 2010


Hi Maciej,

> broke MIPS/LD testsuite, because (despite the innocent description) it
> added semantic changes.

Sorry for that.

> Here's the offending hunk:

> -	  printf ("Hard float (-mdouble-float)\n");
> +	  printf (_("Hard float (double precision)\n"));

> While the changes to the messages might have been legitimate (what was the
> reason behind them BTW? -- I don't find the new ones any better than the
> old ones),

The reason was that the output was referring to command line options 
that are specific to GCC, which I felt was incompatible with readelf's 
mission to work with any ELF binary, regardless of which compiler 
produced it.

>   Here are the test case updates required unless we revert the semantic
> changes above.  Tested with mips-sde-elf and mips-linux-gnu targets.
> Comments?

Approved - please apply.

>   If the change is to stay, then we may as well fix up the old ChangeLog
> entry.  I can do this while committing this testsuite update; at this
> point it seems to make sense to do all of this with a single commit.

Agreed.

Cheers
   Nick




More information about the Binutils mailing list