[Patch 2/4] Rewrite of the alpha-vms bfd back-end (bfd)

[Tristan Gingold]

On Apr 13, 2010, at 1:12 PM, Nick Clifton wrote:

> Hi Tristan,

[...]

> Approved - please apply.

Thank you for the reviews.

> Some comments:
> 
> +/* Read & process EIHD record.
> +   Return 0 on success, -1 on error  */
> +
> +static int
> +_bfd_vms_slurp_eihd (bfd *abfd, unsigned int *eisd_offset,
> +                     unsigned int *eihs_offset)
> 
> Why not use bfd_boolean as the return type here ?  (And for other, similar functions ...)

Right.  Many functions that were moved from old vms-hdr.c/vms-tir.c/vms-gsd.c/vms.c used int as a status
return type.  I changed some of these but I no of all them.  Will do it.

> +	  sprintf (name, "$%s_%03d$", pfx, section_count++);
> 
> Is it (theoretically) possible to have more than 999 EISD records ?  If so then maybe an assertion or range check would be appropriate here.

I suppose this is theoretically possible.  An assert won't harm.

Tristan.