[PATCH, ARM] Handle non-core registers in GAS' CFI statement parser
Nick Clifton
nickc@redhat.com
Tue Apr 6 11:57:00 GMT 2010
Hi Thomas,
> gas/
> 2010-03-26 Thomas Schwinge<thomas@codesourcery.com>
>
> * config/tc-arm.c (tc_arm_regname_to_dw2regnum): Re-implement in order
> to also handle non-core registers.
Approved - but please could you also create a test case to check this
new behaviour please.
> - if (reg == FAIL)
> + if (!reg)
> return -1;
This is just my opinion here but I would suggest testing "if (reg ==
NULL)" here since I think that it makes it clearer that reg is a pointer
not an integer.
Cheers
Nick
More information about the Binutils
mailing list