[PATCH, Take 2] Gold: Added R_ARM_ABS8 relocation unit test

Ian Lance Taylor iant@google.com
Sun Sep 27 07:35:00 GMT 2009


Viktor Kutuzov <vkutuzov@accesssoftek.com> writes:

> Please find attached the updated patch for the R_ARM_ABS8 relocation unit test.

I appreciate all the hard work you've done here, but this doesn't seem
like the right approach to me.

For standard relocations like 8-bit absolute we can write a reasonably
standard test.  We don't need to write a target dependent test.

I think we can make these tests more robust by using special section
names.

I don't understand your check_relocation_abs test.  As far as I can
tell, what it tests is that the final value of a symbol is the value
in the object file plus the offset of the section in the executable.
It doesn't seem to test the relocation value.

What I'm thinking is something along the lines of the appended,
although that is incomplete.

Ian


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-diff
Size: 6055 bytes
Desc: reloc test
URL: <https://sourceware.org/pipermail/binutils/attachments/20090927/2a107900/attachment.bin>


More information about the Binutils mailing list