[PATCH 1/2] gold: try to open the output file in incremental build and check

[Mikolaj Zalewski]

On Tue, Sep 22, 2009 at 2:03 AM, Ian Lance Taylor <iant@google.com> wrote:
> Mikolaj Zalewski <mikolajz@google.com> writes:
>
>> http://sourceware.org/ml/binutils/2009-09/msg00331.html . In the
>> original version, I didn't include <auto_ptr.h> and this caused the
>> build to fail on OpenSUSE 11.1 (I didn't notice it because on an older
>> Ubuntu it worked).
>
> I have to say that I really don't like auto_ptr and I would prefer
> almost any other solution.  Sorry for not looking at this earlier.
>
> I believe that auto_ptr will be deprecated in C++0x.

  I've made a patch without auto_ptr.
  BTW, you don't like auto_ptr because of the implicit passing of
ownership in operator=()?

2009-09-11  Mikolaj Zalewski  <mikolajz@google.com>

      * elf_file.h: Fix header guard.
      (Elf_recognizer): New class, code from gold/object.cc.
      (Elf_file::find_section_by_type): New method.

gold:

2009-09-11  Mikolaj Zalewski  <mikolajz@google.com>

      * incremental.cc: Include <stdarg>.
      Include "target-select.h".
      (vexplain_no_incremental): New function.
      (explain_no_incremental): New function.
      (Incremental_binary::error): New method.
      (Sized_incremental_binary::do_find_incremental_inputs_section):
New method.
      (make_sized_incremental_binary): New function.
      (open_incremental_binary): New function.
      (can_incrementally_link_file): Add checks if output is ELF and
has inputs section.
      * incremental.h: Include "elf_file.h".
      Include "output.h".
      (Incremental_binary): New class.
      (Sized_incremental_binary): New class.
      (open_incremental_binary): Declare.
      * object.cc (is_elf_object): Use elfcpp::Elf_recognizer::is_elf_file.
      (make_elf_object): Use elfcpp::Elf_recognizer::is_valid_header.
      * output.cc (Output_file::filesize): New method.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-gold-try-to-open-the-output-file-in-incremental-bui.patch
Type: text/x-patch
Size: 19371 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090922/60727206/attachment.bin>