[PATCH Take 2] Gold: Added R_ARM_ABS8 relocation

Ian Lance Taylor iant@google.com
Fri Sep 18 00:48:00 GMT 2009


Viktor Kutuzov <vkutuzov@accesssoftek.com> writes:

> Please find attached the updated patch.
>
> By the way, I notice that there is a mix of spaces and tabs used in the source code for indents.
> I have done my best trying to follow the original stile.
> But it might be a formal policy I should follow?

There is a formal policy: tabs are at 8-space boundaries in all GNU
code.  I fixed the indentation in your patch.

I also changed the warnings to errors since gold is actually generating
incorrect output in that case.  I also avoided 1 << 31, since that value
is not representable in int32_t.

Applied as follows.

Sorry for the long delay.  Thanks for the patch.

Ian


2009-09-17  Viktor Kutuzov  <vkutuzov@accesssoftek.com>

	* arm.cc (has_signed_unsigned_overflow): New function.
	(Arm_relocate_functions::abs8): New function.
	(Target_arm::Scan::local): Handle R_ARM_ABS8.
	(Target_arm::Scan::global): Likewise.
	(Target_arm::relocate::relocate): Likewise.
	(Target_arm::Relocatable_size_for_reloc::get_size_for_reloc):
	Likewise.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-patch
Size: 4001 bytes
Desc: R_ARM_ABS8
URL: <https://sourceware.org/pipermail/binutils/attachments/20090918/8a92c012/attachment.bin>


More information about the Binutils mailing list