[patch] ld test suite for cr16-elf target

Nick Clifton nickc@redhat.com
Wed Sep 9 11:54:00 GMT 2009


Hi Swami,

> OK. I could update the ChangeLog with a reason for setup in XFAIL list 
> as show below:
> ====
>     M R Swami Reddy <MR.Swami.Reddy@nsc.com>
> 
>    * ld-elf/merge.d: Added cr16-*-* to xfail list, as this target 
> doesn't support
>    combining symbols of different segments.
> ===
> Is it OK?

Actually it would be better to put the comment into the testcase.  Ie 
something like:


Index: merge.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/merge.d,v
retrieving revision 1.12
diff -u -r1.12 merge.d
--- merge.d     7 Mar 2009 23:42:28 -0000       1.12
+++ merge.d     8 Sep 2009 07:34:11 -0000
@@ -1,7 +1,7 @@
#source: merge.s
#ld: -T merge.ld
#objdump: -s
# Fails on targets which do not support computing the difference of two
# symbols in different segments.  Eg: CR16.
#xfail: "arc-*-*" "avr-*-*" "bfin-*-*" "cr16-*-*" "cris*-*-*" "crx-*-*" 
"d10v-*-*" "d30v-*-*"


Cheers
   Nick



More information about the Binutils mailing list