[commit] binutils/ Makefile.am missing dependency

[Jan Kratochvil]

On Sat, 05 Sep 2009 13:39:52 +0200, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> > --- src/binutils/Makefile.am	2009/09/01 20:56:51	1.118
> > +++ src/binutils/Makefile.am	2009/09/05 11:09:34	1.119
> > @@ -432,6 +432,7 @@
> >  coffdump_SOURCES = coffdump.c coffgrok.c $(BULIBS)
> >  
> >  sysdump_SOURCES = sysdump.c $(BULIBS)
> > +sysdump.o: sysroff.c
> 
> I think that should use $(OBJEXT).  The automake docs also suggest
> BUILT_SOURCES for such a case.

Did not think much and copied the existing "srconv.o: sysroff.c" rule there...

* $(OBJEXT) is not in use in binutils currently at all, I guess there is no
  support BUILD system requiring it, is it?

* Ralf, is there a reason why BUILT_SOURCES does not contain
  $(GENERATED_CFILES)?  Wouldn't it make these custom rules in .am obsolete?

  dlltool.o:
  if am__fastdepCC
  	$(COMPILE) -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@  $(DLLTOOL_DEFS) $(srcdir)/dlltool.c
  	mv -f $(DEPDIR)/$*.Tpo $(DEPDIR)/$*.Po
  else
  if AMDEP
  	source='dlltool.c' object='$@' libtool=no @AMDEPBACKSLASH@
  	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
  endif
  	$(COMPILE) -c $(DLLTOOL_DEFS) $(srcdir)/dlltool.c
  endif


Thanks,
Jan