PATCH: Use enum instead of nested macros in i386-opc.h

H.J. Lu hjl.tools@gmail.com
Fri Oct 16 17:41:00 GMT 2009


On Fri, Oct 16, 2009 at 10:14 AM, David Daney <ddaney@caviumnetworks.com> wrote:
> H.J. Lu wrote:
> [...]
>>
>> +enum
>> +{
>> +  /* i186 or better required */
>> +  Cpu186 = 0,
>
> [...]
>>
>> +enum
>> +{
>> +  /* has direction bit. */
>> +  D = 0,
>
> [...]
>>
>> +enum
>> +{
>> +  /* 8bit register */
>> +  Reg8 = 0,
>
> Putting on my pedant's hat: All those '= 0' are redundant.
>

I will leave it there if it doesn't hurt.

Thanks.


-- 
H.J.



More information about the Binutils mailing list