[COMMITTED PATCH] Fix %s that should be %B in several message formats.

Alan Modra amodra@bigpond.net.au
Tue Oct 13 23:40:00 GMT 2009


On Tue, Oct 13, 2009 at 11:18:20AM -0700, Roland McGrath wrote:
> > Your patch is obviously incorrect, except for the last place you
> > change.  Please fix.
> 
> That last place was the actual one I had noticed and (knew how to) test.
> I'm confused about how the other cases I changed differ from that one.
> They pass a bfd * argument to (*_bfd_error_handler) first after the format,
> corresponding to a %s in the format.

_bfd_default_error_handler is out to get you. :-)  Incidentally, my
"obviously incorrect" comment refers to the fact that your patch
resulted in all the format specs being %B but one of the args
remaining a string.  I should have explained, sorry.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list