[PATCH 1/2] gold: try to open the output file in incremental build and check

Ian Lance Taylor iant@google.com
Fri Oct 9 16:42:00 GMT 2009


Mikolaj Zalewski <mikolajz@google.com> writes:

> 2009-09-11  Mikolaj Zalewski  <mikolajz@google.com>
>
>       * elf_file.h: Fix header guard.
>       (Elf_recognizer): New class, code from gold/object.cc.
>       (Elf_file::find_section_by_type): New method.
>
> gold:
>
> 2009-09-11  Mikolaj Zalewski  <mikolajz@google.com>
>
>       * incremental.cc: Include <stdarg>.
>       Include "target-select.h".
>       (vexplain_no_incremental): New function.
>       (explain_no_incremental): New function.
>       (Incremental_binary::error): New method.
>       (Sized_incremental_binary::do_find_incremental_inputs_section):
> New method.
>       (make_sized_incremental_binary): New function.
>       (open_incremental_binary): New function.
>       (can_incrementally_link_file): Add checks if output is ELF and
> has inputs section.
>       * incremental.h: Include "elf_file.h".
>       Include "output.h".
>       (Incremental_binary): New class.
>       (Sized_incremental_binary): New class.
>       (open_incremental_binary): Declare.
>       * object.cc (is_elf_object): Use elfcpp::Elf_recognizer::is_elf_file.
>       (make_elf_object): Use elfcpp::Elf_recognizer::is_valid_header.
>       * output.cc (Output_file::filesize): New method.

Committed as follows.  I renamed bitness to size, adjusted a few
comments and formatting.

Thanks, and sorry for the delay.

Ian


elfcpp/:

2009-10-09  Mikolaj Zalewski  <mikolajz@google.com>

	* elfcpp_file.h: Fix header guard.  Include <cstdio>.
	(class Elf_recognizer): New class, code from gold/object.cc.
	(Elf_file::find_section_by_type): New method.

gold/:

2009-10-09  Mikolaj Zalewski  <mikolajz@google.com>

	* incremental.cc: Include <cstdarg> and "target-select.h".
	(vexplain_no_incremental): New function.
	(explain_no_incremental): New function.
	(Incremental_binary::error): New method.
	(Sized_incremental_binary::do_find_incremental_inputs_section): New
	method.
	(make_sized_incremental_binary): New function.
	(open_incremental_binary): New function.
	(can_incrementally_link_file): Add checks if output is ELF and has
	inputs section.
	* incremental.h: Include "elfcpp_file.h" and "output.h".
	(Incremental_binary): New class.
	(Sized_incremental_binary): New class.
	(open_incremental_binary): Declare.
	* object.cc (is_elf_object): Use
	elfcpp::Elf_recognizer::is_elf_file.
	(make_elf_object): Use elfcpp::Elf_recognizer::is_valid_header.
	* output.h (Output_file::filesize): New method.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-diff
Size: 20386 bytes
Desc: incremental
URL: <https://sourceware.org/pipermail/binutils/attachments/20091009/23cbc958/attachment.bin>


More information about the Binutils mailing list