objdump patch: arm disassembly with no symbols bug fixed

Paul Reed paulreed@paddedcell.com
Fri Oct 2 20:51:00 GMT 2009


Hi folks,

I've just submitted a one-line patch to objdump, for feedback, on bugzilla
#10341 (I'm not sure how to submit this to CVS, see also at the end of
this email for the same patch).

http://sourceware.org/bugzilla/show_bug.cgi?id=10341

This allows ARM binaries without symbols (even raw binaries) to be
disassembled, instead of segfaulting.

Since you're planning a release soon, I wondered whether someone might
take a look.  Maybe it's too close.

Feel free to contact me if you need any clarification.

Cheers
Paul Reed
http://www.paddedcell.com


--- opcodes/arm-dis.c	2009-10-02 20:21:06.000000000 +0100
+++ opcodes/arm-dis.c.new	2009-10-02 20:14:19.000000000 +0100
@@ -3993,8 +3993,7 @@

   /* First check the full symtab for a mapping symbol, even if there
      are no usable non-mapping symbols for this address.  */
-  if (info->symtab != NULL
-      && * info->symtab
+  if (info->symtab_size != 0
       && bfd_asymbol_flavour (*info->symtab) == bfd_target_elf_flavour)
     {
       bfd_vma addr;




More information about the Binutils mailing list