PATCH, libiberty: eliminate build warning

Ian Lance Taylor iant@google.com
Mon Nov 23 04:03:00 GMT 2009


Ben Elliston <bje@au1.ibm.com> writes:

> -#define writeerr(s) (void) write (STDERR_FILE_NO, s, strlen (s))
> +  int retval = 0;
> +#define writeerr(s) retval |= write (STDERR_FILE_NO, s, strlen (s))

It seems to me that it should be
  #define writeerr(s) retval |= write (STDERR_FILE_NO, s, strlen (s)) < 0

This is OK with that change if it makes sense to you.

Ian



More information about the Binutils mailing list