[Patch]: fix bfd/targets.c build failure on AIX
Tristan Gingold
gingold@adacore.com
Tue Nov 17 14:40:00 GMT 2009
On Nov 17, 2009, at 3:28 PM, Alan Modra wrote:
> On Tue, Nov 17, 2009 at 02:00:48PM +0100, Tristan Gingold wrote:
>> So, do we accept alloca in targets.c ?
>
> I think we could easily use a fixed size buffer, since the code in
> bfd_get_target_info is using alloca for (part of) target_vec->name.
> The largest target_vec->name is currently 24 chars. A buffer twice
> that size should be ample.
Fine.
>> Maybe we should also clearly document in alloca-conf.h that this
>> file must be the first include.
>
> We do have a comment that says in part: "Some versions of AIX require
> this to be the first thing in the file except for comments and
> preprocessor directives."
>
> s/in the file/seen by the compiler/ would be clearer.
For the record this seems to be required by IBM C/C++ compiler version 3.6, available with AIX 4.3 (around 1998)
Not sure we still support this version, but it doesn't hurt.
Thanks,
Tristan.
More information about the Binutils
mailing list