[GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions

Nick Clifton nickc@redhat.com
Mon Nov 16 11:48:00 GMT 2009


Hi Viktor,

> Please find attached the updated patch.
> 
> * Literal 15 changed to REG_PC and added comment about APSR_nzcv encoding.
> * Fixed comment formatting.
> * Added unit tests to gas/testsuite/gas/arm/vfp1xD.s and vfp1xD.d to check the assembly of the vmsr and vmrs instructions.

Thanks for addressing these points.  I have checked your patch in, with 
one small change - I reduced the number of NOP instructions at the end 
of the vfp1xD.s file from two to one.  These nops were there in order to 
make sure that the assembled section ended on a 16-byte boundary, 
(needed for the arm-aout target).

I also created two changelog entries for the patch, as shown below.

Cheers
   Nick

gas/ChangeLog
2009-11-16  Viktor Kutuzov  <vkutuzov@accesssoftek.com>

	* config/tc-arm.c (parse_operands): Encode APSR_nzcv as r15.
	(do_vmrs): New function.
	(do_vmsr): New function.
	(insns): Add vmrs and vmsr.

gas/testsuite/ChangeLog
2009-11-16  Viktor Kutuzov  <vkutuzov@accesssoftek.com>

	* gas/arm/vfp1xD.s: Add vmrs and vmsr instructions.
	* gas/arm/vfp1xD.d: Update expected disassembly.



More information about the Binutils mailing list