[patch] Add bfd_target_info function to bfd and unify windres/windmc target information gathering

Kai Tietz ktietz70@googlemail.com
Sun Nov 15 08:14:00 GMT 2009


2009/11/14 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Kai Tietz wrote:
>> Dave,
>>
>> thanks, here is updated version.
>
>  You still missed one superfluous space:
>
>>  const bfd_target *bfd_find_target (const char *target_name, bfd *abfd);
>>
>> +const bfd_target * bfd_get_target_info (const char *target_name,
>                     ^
>  The asterisk always goes hard up against the symbol, because that's how it
> binds (the canonical example being "char* x,y;" vs. "char *x,y;").  Everything
> else looked good.
>
>    cheers,
>      DaveK
>

Ah, the prototype in comment, which gets exported into bfd-in2.h I've missed.

Here is updated patch.

Ok for apply?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bfd_target_info.diff
Type: application/octet-stream
Size: 7858 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20091115/02fe3f57/attachment.obj>


More information about the Binutils mailing list