[GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions

[Nick Clifton]

Hi Viktor,

> Attached is a patch that adds a support for the ARM VMSR and VMRS 
> instructions.

The patch is mostly OK, but there are a few issues:

   --- gas/config/tc-arm.c	3 Nov 2009 12:37:44 -0000	1.413
   +++ gas/config/tc-arm.c	11 Nov 2009 02:22:49 -0000
   @@ -6303,6 +6395,7 @@
                  if (found != 15)
                    goto failure;
                  inst.operands[i].isvec = 1;
   +	      inst.operands[i].reg = 15;
                }
              else
                goto failure;

What is the purpose of this change ?


   +  /* APSR_ sets isvec. All other refs to PC are illegal */

Comment formatting.  Should end:  illegal.  */


One other point.  Please could you add a couple of lines to 
gas/testsuite/gas/arm/vfp1xD.s and vfp1xD.d to check the assembly of the 
vmsr and vmrs instructions ?

Cheers
   Nick