Fix RUNTESTFLAGS "foo.exp=bar" syntax for ld link tests.

Dave Korn dave.korn.cygwin@googlemail.com
Mon May 18 17:31:00 GMT 2009


    Hi all,

  I just noticed that the RUNTESTFLAGS test-selector syntax isn't fully
implemented in the ld testsuite.  Dump tests respect it, but link tests don't,
leading to this sort of behaviour:


admin@ubik /usr/build/obj-binutils
$ make -k check-ld RUNTESTFLAGS="-all pe.exp=foobar"
   [ ... snips ... ]
		=== ld tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /usr/build/src-binutils/ld/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /usr/build/src-binutils/ld/testsuite/ld-pe/pe.exp ...
PASS: .secrel32
PASS: Empty export table

		=== ld Summary ===

# of expected passes		2
/usr/build/obj-binutils/ld/ld-new 2.19.51.20090517


  The attached patch adds the missing check, and correctly filters the list of
tests.

ld/testsuite/ChangeLog:

	* lib/ld-lib.exp (run_ld_link_tests):  Filter test names against
	runtests list.

  Ok?

    cheers,
      DaveK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ld-lib-exp-saved-patch.diff
Type: text/x-c
Size: 721 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090518/08870d01/attachment.bin>


More information about the Binutils mailing list