[committed] Re: Re: [PATCH] Windows/PE: Do not create empty export table.
Dave Korn
dave.korn.cygwin@googlemail.com
Sun May 17 05:14:00 GMT 2009
Aaron W. LaFramboise wrote:
> Danny Smith wrote:
>
>> This patch will also change the default behaviour to "export
>> everything else the default way"
>> when there is no .def file and no symbols marked with export directive"
>>
>> Shouldn't we rather test for an empty export table later on like so:
>
> You're right; checking here seems a lot better.
>
> I've tested this version on i386-pc-mingw32 with a build and testsuite
> run, with no regressions.
>
> OK to commit?
The patch is OK. I've refreshed it up to HEAD, extended the testcase to
also cover Cygwin and MinGW-w64, retested it and applied it. Thanks, guys,
and Kai too, for digging up this lost patch.
cheers,
DaveK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: empty-exports-applied.diff
Type: text/x-c
Size: 4060 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090517/bc917939/attachment.bin>
More information about the Binutils
mailing list