[PATCH] gold: create .gnu_incremental_inputs entries for inputs

Ian Lance Taylor iant@google.com
Fri May 15 17:01:00 GMT 2009


Mikolaj Zalewski <mikolajz@google.com> writes:

>   This patch stores some data for inputs entries. It does not yet
> create entries for archive members, doesn't store the extra type
> specific information nor save the timestamp, but all this can be fixed
> later if the approach in this patch is good. A file added by a plugin
> is currently  an error - I will look into plug-ins later.
>   Incremental link needs more information about input element that I
> have found gold to save, so I'm storing the extra information in a map
> in Incremental_inputs. It could be added as extra fields to
> Input_argument, but then the structure wouldn't be immutable anymore
> and there would be a slight memory overhead for non-incremental
> builds.

I would consider simply adding a pointer to Input_argument, rather than
using Increment_inputs::inputs_map_.  And I would use a union in
Incremental_inputs::Input_info.  But this code is OK, and I committed it
with some formatting changes.  Particular changes: two spaces after the
end of a sentence in a comment, and line up function arguments under
parentheses rather than using a four space continuation indent.  Also,
the ChangeLog entry is a lot better, thanks, but the text should be
sentences with a capital letter and a period.

Thanks.  Committed.

Ian



More information about the Binutils mailing list