Fix arm-eabi attributes

Nathan Sidwell nathan@codesourcery.com
Fri May 1 07:08:00 GMT 2009


Richard Earnshaw wrote:
> On Thu, 2009-04-30 at 15:24 +0100, Nathan Sidwell wrote:
>> This patch fixes a latent problem with arm eabi attributes.  We triggered off 
>> TE_LINUX when defaulting the FPU, thus leading to a lack of default for plain 
>> arm-eabi, leading to incorrect object files.
>>
> 
>> ! #if !(defined (TE_LINUX) || defined (TE_NetBSD) || defined (TE_VXWORKS))
>>         /* Some environments specify a default FPU.  If they don't, infer it
>>   	 from the processor.  */
>>         if (mcpu_fpu_opt)
>> --- 20267,20273 ----
>>       }
>>     else if (!mfpu_opt)
>>       {
>> ! #if !(defined (EABI_DEFAULT) || defined (TE_NetBSD) || defined (TE_VXWORKS))
> 
> I'm not sure that's right for legacy linux (which defaults to FPA);
> shouldn't you just add EABI_DEFAULT to the list rather than replace
> TE_LINUX with it?

I don't know.  I thought this was what we'd agreed on though :)

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery



More information about the Binutils mailing list