Fix ARM SymbianOS dynamic relocations

Daniel Jacobowitz drow@false.org
Tue Mar 17 14:52:00 GMT 2009


Third time's the charm.  I've tested this on arm-symbianelf and
arm-none-linux-gnueabi; no change on Linux but it makes dynamic
relocation sections properly not allocated on Symbian OS.

Checked in to HEAD.

-- 
Daniel Jacobowitz
CodeSourcery

2009-03-17  Daniel Jacobowitz  <dan@codesourcery.com>

	bfd/
	* elf32-arm.c (elf32_arm_check_relocs): Correct symbian_p test.

Index: bfd/elf32-arm.c
===================================================================
--- bfd/elf32-arm.c	(revision 240283)
+++ bfd/elf32-arm.c	(working copy)
@@ -10043,12 +10043,12 @@ elf32_arm_check_relocs (bfd *abfd, struc
 		      return FALSE;
 
 		    /* BPABI objects never have dynamic relocations mapped.  */
-		    if (! htab->symbian_p)
+		    if (htab->symbian_p)
 		      {
 			flagword flags;
 
 			flags = bfd_get_section_flags (dynobj, sreloc);
-			flags |= (SEC_LOAD | SEC_ALLOC);
+			flags &= ~(SEC_LOAD | SEC_ALLOC);
 			bfd_set_section_flags (dynobj, sreloc, flags);
 		      }
 		  }



More information about the Binutils mailing list