PATCH: PR ld/9938: TLS transition from R_386_TLS_GD to R_386_TLS_IE_32 error
H.J. Lu
hjl.tools@gmail.com
Thu Mar 12 21:32:00 GMT 2009
On Thu, Mar 12, 2009 at 2:01 PM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> - && (strcmp (h->root.root.string, "___tls_get_addr") == 0));
>> + && (strncmp (h->root.root.string, "___tls_get_addr",
>> + 15) == 0));
>
> I think you should write
> strncmp (h->root.root.string, "___tls_get_addr", 15) == 0
> && (h->root.root.string[15] == '\0'
> || h->root.root.string[15] == '@')
>
I thought about it. This is a sanity check. All other ELF targets don't
have any check at all. I tried to avoid slowing down linker further. But
if someone wants to add it, it is OK with me. It should check
ELF_VER_CHR instead of '@'.
--
H.J.
More information about the Binutils
mailing list